ankitsultana commented on code in PR #17484:
URL: https://github.com/apache/pinot/pull/17484#discussion_r2684010095


##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -641,6 +648,20 @@ private TimeSeriesBlock executeTimeSeriesQuery(String 
language, String queryStri
         requesterIdentity, httpHeaders);
   }
 
+  /**
+   * Checks if the timeseries request is an explain mode request.
+   * Looks for "mode": "explain" in the queryOptions field.
+   */
+  private static boolean isExplainMode(JsonNode requestJson) {
+    if (requestJson.has("queryOptions")) {

Review Comment:
   I think we should decouple this from queryOptions and just set it as a 
top-level key.
   
   Technically speaking, queryOptions should map 1:1 to Pinot SQL's query 
options



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to