anuragrai16 commented on code in PR #17502:
URL: https://github.com/apache/pinot/pull/17502#discussion_r2703247054
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -522,6 +522,10 @@ private BrokerResponse
query(QueryEnvironment.CompiledQuery query, long requestI
RequesterIdentity requesterIdentity, RequestContext requestContext,
HttpHeaders httpHeaders, Timer timer,
boolean rlsFiltersApplied)
throws QueryException, WebApplicationException {
+ // Strip any user-supplied internal-only options to prevent spoofing.
These will be set programmatically later.
+ // NOTE: 'leafLimitProvenance' is internal and must not be accepted from
client input.
Review Comment:
Is this the only occurrence of internal-only options ? Can we make it a
constant set that can be added to and a function that reads the set and removes
it so it can be reused across.
##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java:
##########
@@ -151,11 +151,13 @@ enum MetadataKey {
// Needed so that we can track workload name in Netty channel response.
WORKLOAD_NAME(40, "workloadName", MetadataValueType.STRING),
// Needed so that we can track query id in Netty channel response.
- QUERY_ID(41, "queryId", MetadataValueType.STRING);
+ QUERY_ID(41, "queryId", MetadataValueType.STRING),
+ LEAF_TRUNCATION_REASON(42, "leafTruncationReason",
MetadataValueType.STRING),
+ LITE_LEAF_CAP_TRUNCATION(43, "liteLeafCapTruncation",
MetadataValueType.BOOLEAN);
Review Comment:
Is the limit only meant for MSE Lite ? And is the implementation different
from how MSE handles default limits ?
Also, can we keep naming consistent : `LITE_LEAF_CAP_TRUNCATION` and
`LITE_LEAF_TRUNCATION_REASON` if they're linked together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
