Copilot commented on code in PR #17536:
URL: https://github.com/apache/pinot/pull/17536#discussion_r2713613575
##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManagerTest.java:
##########
@@ -159,6 +161,19 @@ private Schema getSchemaWithExtraColumn() {
.build();
}
+ private File createSegmentFromCsv(File csvFile, TableConfig tableConfig,
Schema schema, String segmentName)
+ throws Exception {
+ File tableDataDir = new File(TEMP_DIR, OFFLINE_TABLE_NAME + "_upsert");
Review Comment:
The hardcoded suffix '_upsert' in the directory name could cause collisions
if `createSegmentFromCsv` is called multiple times in the same test or across
tests. Consider using a unique directory name per invocation, such as appending
the segment name or a timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
