Copilot commented on code in PR #17182: URL: https://github.com/apache/pinot/pull/17182#discussion_r2752349529
########## pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ArrayJoinContext.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.common.request.ArrayJoinType; +import org.apache.pinot.common.request.context.ExpressionContext; + + +public class ArrayJoinContext { + private final ArrayJoinType _type; + private final List<Operand> _operands; + + public ArrayJoinContext(ArrayJoinType type, List<Operand> operands) { + _type = type; + _operands = operands; + } + + public ArrayJoinType getType() { + return _type; + } + + public List<Operand> getOperands() { + return _operands; + } + Review Comment: Missing class-level Javadoc for the Operand inner class. Add documentation explaining what an operand represents in the ARRAY JOIN context. ```suggestion /** * Represents a single operand in an ARRAY JOIN clause. * <p> * Each operand defines an {@link ExpressionContext} whose array-valued result is * joined/unnested according to the {@link ArrayJoinType}, and an optional alias * that names the corresponding output column in the query result. */ ``` ########## pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ArrayJoinContext.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.common.request.ArrayJoinType; +import org.apache.pinot.common.request.context.ExpressionContext; + + Review Comment: Missing class-level Javadoc. Add documentation explaining the purpose of this class, what it represents in the context of ARRAY JOIN operations, and how it's used in query execution. ```suggestion /** * Context object that captures the logical description of an {@code ARRAY JOIN} clause in a query. * <p> * An {@code ArrayJoinContext} is created during query parsing and planning to record: * <ul> * <li>The {@link ArrayJoinType} indicating how array values should be expanded or combined.</li> * <li>The ordered list of {@link Operand operands}, each wrapping the expression to apply the * ARRAY JOIN to, along with an optional result alias.</li> * </ul> * Query execution components use this context to drive how array-valued expressions are * transformed into individual rows or columns when evaluating ARRAY JOIN operations. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
