Jackie-Jiang commented on code in PR #17626:
URL: https://github.com/apache/pinot/pull/17626#discussion_r2766133273
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskExecutor.java:
##########
@@ -231,7 +232,7 @@ private SegmentGenerationJobSpec generatePushJobSpec(String
tableName, Map<Strin
spec.setPushJobSpec(pushJobSpec);
spec.setTableSpec(tableSpec);
spec.setPinotClusterSpecs(pinotClusterSpecs);
- spec.setAuthToken(taskConfigs.get(BatchConfigProperties.AUTH_TOKEN));
+
spec.setAuthToken(AuthProviderUtils.toStaticToken(resolveAuthProvider(taskConfigs)));
Review Comment:
When only auth token is required, we don't need to construct the auth
provider. We should add a util method to `resolveAuthToken(taskConfigs)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
