justahuman1 commented on code in PR #17660:
URL: https://github.com/apache/pinot/pull/17660#discussion_r2778063849
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -544,21 +544,64 @@ public static String[] suffixesWithSuffix(String input,
int maxlength, @Nullable
/**
* TODO: Revisit if index should be one-based (both Presto and Postgres use
one-based index, which starts with 1)
- * @param input
- * @param delimiter
+ * @param input the input String to be split into parts.
Review Comment:
copied verbatim from the the overloaded `splitPart` function below to keep
in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
