suvodeep-pyne commented on code in PR #17674:
URL: https://github.com/apache/pinot/pull/17674#discussion_r2789750665
##########
pom.xml:
##########
@@ -2929,6 +2929,9 @@
<!-- Solve NoClassDefFoundError. Borrowed from
https://github.com/prometheus/jmx_exporter/issues/802 -->
<exclude>META-INF/versions/9/org/yaml/snakeyaml/internal/**</exclude>
+
+ <!-- Exclude NettyInstacne because it includes Netty package
literals -->
Review Comment:
This looks a bit fragile. Should we load the strings from somewhere instead?
I understand the motivation but thing is 1 rename or package move and it might
break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
