Jackie-Jiang commented on code in PR #17532: URL: https://github.com/apache/pinot/pull/17532#discussion_r2791042010
########## pinot-broker/src/main/java/org/apache/pinot/broker/routing/manager/BaseBrokerRoutingManager.java: ########## @@ -123,6 +130,8 @@ public abstract class BaseBrokerRoutingManager implements RoutingManager, Cluste protected final BrokerMetrics _brokerMetrics; protected final Map<String, RoutingEntry> _routingEntryMap = new ConcurrentHashMap<>(); + // Additional sampler-specific routing components per table, keyed by normalized sampler name. + protected final Map<String, Map<String, SamplerInfo>> _samplerRoutingEntryMap = new ConcurrentHashMap<>(); Review Comment: You can put `Map<String, SamplerInfo>` as one member variable within the `RoutingEntry`, then all the methods within `RoutingEntry` can directly handle the samplers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
