xiangfu0 opened a new pull request, #17707: URL: https://github.com/apache/pinot/pull/17707
## What - avoid eager full IdealState fetch in `commitSegmentMetadataInternal` - move CONSUMING-state validation into the Step-3 IdealState updater (same snapshot used for mutation) - make partition-id fallback to IdealState lazy via `Supplier` so normal commits skip large IS fetch - add best-effort cleanup for newly-created segment metadata when Step-3 fails or does not add the segment - gate segment movement on whether the new segment is actually present in updated IdealState ## Test - `timeout 600 ./mvnw -pl pinot-controller -DskipTests compile` - `timeout 600 ./mvnw -pl pinot-controller -Dtest=PinotLLCRealtimeSegmentManagerTest -Dsurefire.failIfNoSpecifiedTests=false test` ## Why For very large realtime tables, loading full IdealState during each commit can amplify controller heap pressure. This change keeps correctness checks while reducing unnecessary large-object materialization on the common commit path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
