This is an automated email from the ASF dual-hosted git repository.
manishswaminathan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 402e88ada4c Revert "Add validation for tiered storage in Upsert/Dedup
tables. (#17064)" (#17726)
402e88ada4c is described below
commit 402e88ada4c4b92bb6254637f19ddc8197eb66b7
Author: Shounak kulkarni <[email protected]>
AuthorDate: Thu Feb 19 17:36:22 2026 +0530
Revert "Add validation for tiered storage in Upsert/Dedup tables. (#17064)"
(#17726)
This reverts commit 549a47ccec05de2c9533dd40e24c3de472e099a5.
---
.../segment/local/utils/TableConfigUtils.java | 3 --
.../segment/local/utils/TableConfigUtilsTest.java | 53 ++--------------------
2 files changed, 3 insertions(+), 53 deletions(-)
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
index 834516ef417..97623115c3c 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
@@ -776,9 +776,6 @@ public final class TableConfigUtils {
return;
}
- Preconditions.checkState(tableConfig.getTierConfigsList() == null ||
tableConfig.getTierConfigsList().isEmpty(),
- "Tiered storage is not supported for Upsert/Dedup tables");
-
boolean isUpsertEnabled = tableConfig.getUpsertMode() !=
UpsertConfig.Mode.NONE;
boolean isDedupEnabled = tableConfig.getDedupConfig() != null &&
tableConfig.getDedupConfig().isDedupEnabled();
diff --git
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java
index 35a1c6208c6..1488bf81e51 100644
---
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java
+++
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java
@@ -872,9 +872,9 @@ public class TableConfigUtilsTest {
streamIngestionConfigWithoutPauselessUniqueTopics);
TableConfig tableConfigWithoutPauselessUniqueTopics = new
TableConfigBuilder(TableType.REALTIME)
.setTableName(TABLE_NAME)
- .setTimeColumnName("timeColumn")
- .setIngestionConfig(ingestionConfigWithoutPauselessUniqueTopics)
- .build();
+ .setTimeColumnName("timeColumn")
+ .setIngestionConfig(ingestionConfigWithoutPauselessUniqueTopics)
+ .build();
try {
TableConfigUtils.validate(tableConfigWithoutPauselessUniqueTopics,
schema);
} catch (IllegalStateException e) {
@@ -1896,53 +1896,6 @@ public class TableConfigUtilsTest {
}
}
- @Test
- public void testValidateUpsertWithTierConfig() {
- Schema schema = new Schema.SchemaBuilder().setSchemaName(TABLE_NAME)
- .addSingleValueDimension("myCol", FieldSpec.DataType.STRING)
- .setPrimaryKeyColumns(Lists.newArrayList("myCol"))
- .build();
- Map<String, String> streamConfigs = getStreamConfigs();
- UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.FULL);
- TableConfig tableConfig = new
TableConfigBuilder(TableType.REALTIME).setTableName(TABLE_NAME)
- .setUpsertConfig(upsertConfig)
- .setRoutingConfig(
- new RoutingConfig(null, null,
RoutingConfig.STRICT_REPLICA_GROUP_INSTANCE_SELECTOR_TYPE, false))
- .setTimeColumnName(TIME_COLUMN)
- .setStreamConfigs(streamConfigs)
- .setTierConfigList(Lists.newArrayList(
- new TierConfig("tier1", TierFactory.FIXED_SEGMENT_SELECTOR_TYPE,
null, Lists.newArrayList("seg0", "seg1"),
- TierFactory.PINOT_SERVER_STORAGE_TYPE, "tier1_tag_OFFLINE",
null, null)))
- .build();
-
- assertThrows("Tiered storage is not supported for Upsert/Dedup tables",
IllegalStateException.class,
- () -> TableConfigUtils.validateUpsertAndDedupConfig(tableConfig,
schema));
- }
-
- @Test
- public void testValidateDedupWithTierConfig() {
- Schema schema = new Schema.SchemaBuilder().setSchemaName(TABLE_NAME)
- .addSingleValueDimension("myCol", FieldSpec.DataType.STRING)
- .setPrimaryKeyColumns(Lists.newArrayList("myCol"))
- .build();
- Map<String, String> streamConfigs = getStreamConfigs();
- DedupConfig dedupConfig = new DedupConfig();
- dedupConfig.setMetadataTTL(10);
- TableConfig tableConfig = new
TableConfigBuilder(TableType.REALTIME).setTableName(TABLE_NAME)
- .setDedupConfig(dedupConfig)
- .setRoutingConfig(
- new RoutingConfig(null, null,
RoutingConfig.STRICT_REPLICA_GROUP_INSTANCE_SELECTOR_TYPE, false))
- .setTimeColumnName(TIME_COLUMN)
- .setStreamConfigs(streamConfigs)
- .setTierConfigList(Lists.newArrayList(
- new TierConfig("tier1", TierFactory.FIXED_SEGMENT_SELECTOR_TYPE,
null, Lists.newArrayList("seg0", "seg1"),
- TierFactory.PINOT_SERVER_STORAGE_TYPE, "tier1_tag_OFFLINE",
null, null)))
- .build();
-
- assertThrows("Tiered storage is not supported for Upsert/Dedup tables",
IllegalStateException.class,
- () -> TableConfigUtils.validateUpsertAndDedupConfig(tableConfig,
schema));
- }
-
@Test
public void testValidateDedupConfig() {
Schema schema = new Schema.SchemaBuilder().setSchemaName(TABLE_NAME)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
