Jackie-Jiang commented on code in PR #14414:
URL: https://github.com/apache/pinot/pull/14414#discussion_r2849469412
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java:
##########
@@ -53,10 +55,40 @@ default boolean hasAccess(@Nullable String tableName,
AccessType accessType, Htt
* @param endpointUrl the request url for which this access control is called
* @return whether the client has permission
*/
+ @Deprecated
default boolean hasAccess(AccessType accessType, HttpHeaders httpHeaders,
String endpointUrl) {
return hasAccess(null, accessType, httpHeaders, endpointUrl);
}
+ /**
+ * Return whether the client has permission to the given table
+ *
+ * @param tableName name of the table to be accessed
+ * @param accessType type of the access
+ * @param httpHeaders HTTP headers containing requester identity
+ * @param request the request for which this access control is called
+ * @param endpointUrl the request url for which this access control is called
+ * @return whether the client has permission
+ */
+ default boolean hasAccess(@Nullable String tableName, AccessType accessType,
HttpHeaders httpHeaders,
Review Comment:
We are mixing Servlet class and JAX-RS class. Is the required info available
from JAX-RS class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
