cbalci commented on code in PR #17731:
URL: https://github.com/apache/pinot/pull/17731#discussion_r2850383793
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -261,6 +262,34 @@ protected TableAuthorizationResult
hasTableAccess(RequesterIdentity requesterIde
return tableAuthorizationResult;
}
+ /**
+ * Validates that tables can be queried with enableMultiClusterRouting if
and only if they are logical tables.
+ * Physical tables are cluster-specific and cannot be federated across
clusters.
+ * Multi-cluster routing is only supported for logical tables.
+ *
+ * @param tableNames Set of table names to validate
+ * @param queryOptions Map of query options
+ * @throws QueryException if any physical table is queried with
enableMultiClusterRouting=true
+ */
+ protected void validatePhysicalTablesWithMultiClusterRouting(Set<String>
tableNames,
+ Map<String, String> queryOptions) {
Review Comment:
We can assert `tableNames` and `queryOptions` are never null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
