gortiz commented on code in PR #17797:
URL: https://github.com/apache/pinot/pull/17797#discussion_r2878411407
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/ReceivingMailbox.java:
##########
@@ -91,14 +102,42 @@ public void registeredReader(Reader reader) {
_blocks.registerReader(reader);
}
+ /// Sets the context of the thread owning this [ReceivingMailbox].
+ public synchronized void setThreadContext(@Nullable QueryThreadContext
threadContext) {
Review Comment:
So... this is setting a _thread context_ that is shared by multiple threads?
I understand why we do that, but it is a bit confusing
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/ReceivingMailbox.java:
##########
@@ -322,7 +377,7 @@ public List<DataBuffer> getSerializedStats() {
/// +-------------------+ offerEos +-------------------+
/// | WAITING_EOS | -----------> | FULL_CLOSED |
/// +-------------------+ +-------------------+
- /// ```
+ ///```
Review Comment:
nit probably the space is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
