Jackie-Jiang commented on code in PR #17587:
URL: https://github.com/apache/pinot/pull/17587#discussion_r2880059159
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -400,7 +400,7 @@ public void setUpNewTable(TableConfig tableConfig,
IdealState idealState,
List<StreamConfig> streamConfigs =
IngestionConfigUtils.getStreamConfigs(tableConfig);
streamConfigs.forEach(_flushThresholdUpdateManager::clearFlushThresholdUpdater);
InstancePartitions instancePartitions =
getConsumingInstancePartitions(tableConfig);
- int numPartitionGroups = consumeMeta.size();
+ int numPartitionGroups = getPartitionCountForRouting(streamConfigs,
consumeMeta.size());
Review Comment:
Can you calculate this on the caller side and pass it in? This info should
be available when calculating the `consumeMeta`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
