J-HowHuang commented on code in PR #17799:
URL: https://github.com/apache/pinot/pull/17799#discussion_r2881536811
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/FDAwareInstancePartitionSelector.java:
##########
@@ -389,6 +390,11 @@ private boolean isEmpty(int replicaGroupId, int
instanceId) {
* Fill the vacant instances
*/
public void fill(Map<Integer, LinkedHashSet<String>>
faultDomainToCandidateInstancesMap) {
+ // skip filling if there is no candidate instance, which can happen when
minimize data movement is enabled and
+ // no new instances are added to any pool
+ if
(faultDomainToCandidateInstancesMap.values().stream().allMatch(HashSet::isEmpty))
{
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
