Jackie-Jiang commented on code in PR #17812:
URL: https://github.com/apache/pinot/pull/17812#discussion_r2885491399
##########
pinot-common/src/main/java/org/apache/pinot/common/tier/FixedTierSegmentSelector.java:
##########
@@ -39,8 +39,12 @@ public String getType() {
@Override
public boolean selectSegment(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata) {
- return _segmentsToSelect.contains(segmentZKMetadata.getSegmentName()) &&
segmentZKMetadata.getStatus()
- .isCompleted();
+ // ["*"] means select all completed segments
+ if (_segmentsToSelect.contains("*")) {
Review Comment:
Calculate this in the constructor so that we don't need to repeatedly
calculate this for each segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
