Jackie-Jiang commented on code in PR #17817:
URL: https://github.com/apache/pinot/pull/17817#discussion_r2891912676
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -321,9 +324,11 @@ private class ColumnValueReader implements AutoCloseable {
}
private ForwardIndexReaderContext getReaderContext() {
- // Create reader context lazily to reduce the duration of existence
if (!_readerContextCreated) {
_readerContext = _reader.createContext();
Review Comment:
There are a lot of places where `_reader.createContext()` is invoked, e.g.
in `ScanDocIdIterator`. Do we need to also change that?
If we want to adjust context based on query option, I feel passing in query
option into `createContext()` is more intuitive. We can add a default
implementation to fall back to the existing one without argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
