Copilot commented on code in PR #17944:
URL: https://github.com/apache/pinot/pull/17944#discussion_r2976845134
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/MultiStageReplicaGroupSelector.java:
##########
@@ -261,21 +261,15 @@ private Pair<Map<String, String>, Map<String, String>>
computeOptionalSegments(
return Pair.of(segmentsToInstanceMap, optionalSegmentToInstanceMap);
}
-
@VisibleForTesting
protected InstancePartitions getInstancePartitions() {
// TODO: Evaluate whether we need to provide support for COMPLETE
partitions.
Review Comment:
The comment says "COMPLETE partitions", but the relevant enum/type
throughout Pinot is "COMPLETED" (InstancePartitionsType.COMPLETED). This looks
like a typo and can be confusing when searching for the feature.
```suggestion
// TODO: Evaluate whether we need to provide support for COMPLETED
partitions.
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2860,34 +2860,34 @@ public void assignSegments(TableConfig tableConfig,
Map<String, SegmentZKMetadat
}
}
+ /// Fetches or computes the default instance partitions for non-consuming
segments.
Review Comment:
This method is used as the default instance-partitions lookup for both
OFFLINE tables and REALTIME segment assignment (including when CONSUMING is
selected). The doc comment "for non-consuming segments" is misleading; consider
updating it to describe the actual scope (default instance partitions used for
segment assignment, choosing OFFLINE/CONSUMING/COMPLETED depending on table
config).
```suggestion
/// Fetches or computes the default instance partitions used for segment
assignment, selecting the appropriate
/// OFFLINE/CONSUMING/COMPLETED instance partitions based on the table
configuration and existing instance partitions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
