codecov-io commented on issue #4778: Decoupling Server instance name from physical host and port URL: https://github.com/apache/incubator-pinot/pull/4778#issuecomment-549563997 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=h1) Report > Merging [#4778](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/faa068d784aea586a7a7d2f7566b7f82aa24c298?src=pr&el=desc) will **decrease** coverage by `7.93%`. > The diff coverage is `50.79%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4778 +/- ## ============================================ - Coverage 57.95% 50.01% -7.94% Complexity 4 4 ============================================ Files 1209 1210 +1 Lines 64974 65025 +51 Branches 9465 9467 +2 ============================================ - Hits 37653 32520 -5133 - Misses 24455 29938 +5483 + Partials 2866 2567 -299 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/pinot/common/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaGVsaXgvQ2x1c3RlckNoYW5nZU1lZGlhdG9yLmphdmE=) | `73.62% <ø> (ø)` | `0 <0> (?)` | | | [...g/apache/pinot/common/response/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvU2VydmVySW5zdGFuY2UuamF2YQ==) | `78.26% <ø> (-15.22%)` | `0 <0> (ø)` | | | [...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==) | `65.16% <ø> (-3.88%)` | `0 <0> (ø)` | | | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `47.23% <ø> (-43.26%)` | `0 <0> (ø)` | | | [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `0% <0%> (-60%)` | `0 <0> (ø)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `65.8% <100%> (-7.05%)` | `0 <0> (ø)` | | | [...n/java/org/apache/pinot/core/transport/Server.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyLmphdmE=) | `31.25% <16.66%> (-35.42%)` | `0 <0> (ø)` | | | [...not/transport/scattergather/ScatterGatherImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvc2NhdHRlcmdhdGhlci9TY2F0dGVyR2F0aGVySW1wbC5qYXZh) | `54.87% <42.85%> (-0.82%)` | `0 <0> (ø)` | | | [...a/org/apache/pinot/core/transport/QueryRouter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | `87.69% <50%> (-5.53%)` | `0 <0> (ø)` | | | [...e/pinot/common/helix/HelixInstanceConfigCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaGVsaXgvSGVsaXhJbnN0YW5jZUNvbmZpZ0NhY2hlLmphdmE=) | `57.14% <57.14%> (ø)` | `0 <0> (?)` | | | ... and [295 more](https://codecov.io/gh/apache/incubator-pinot/pull/4778/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=footer). Last update [faa068d...7bb936c](https://codecov.io/gh/apache/incubator-pinot/pull/4778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
