npawar commented on a change in pull request #4774: Refactor virtualColumn to
extraColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r342301326
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -409,4 +409,10 @@ public ServerType getServerType() {
public static final String RETRY_WAITIME_MS = "retry.wait.ms";
public static final int RETRY_WAITIME_MS_DEFAULT = 100;
}
+
Review comment:
is Schema the right place for these? Something like Segment.VirtualColumns
would be better I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
