deeppatel710 commented on code in PR #18127:
URL: https://github.com/apache/pinot/pull/18127#discussion_r3077339650
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeOffsetAutoResetManager.java:
##########
@@ -214,13 +215,11 @@ private RealtimeOffsetAutoResetHandler
getOrConstructHandler(TableConfig tableCo
try {
Class<?> clazz = Class.forName(className);
if (!RealtimeOffsetAutoResetHandler.class.isAssignableFrom(clazz)) {
- String exceptionMessage = "Custom analyzer must be a child of "
- + RealtimeOffsetAutoResetHandler.class.getCanonicalName();
- throw new ReflectiveOperationException(exceptionMessage);
+ throw new ReflectiveOperationException("Custom handler must implement "
+ + RealtimeOffsetAutoResetHandler.class.getCanonicalName());
}
- handler = (RealtimeOffsetAutoResetHandler) clazz.getConstructor(
- PinotLLCRealtimeSegmentManager.class,
PinotHelixResourceManager.class).newInstance(
- _llcRealtimeSegmentManager, _pinotHelixResourceManager);
+ handler = (RealtimeOffsetAutoResetHandler)
clazz.getConstructor().newInstance();
Review Comment:
@xiangfu0 how about now? can you review this again please? thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
