xiangfu0 commented on code in PR #18140:
URL: https://github.com/apache/pinot/pull/18140#discussion_r3107399381
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/InvertedIndexHandler.java:
##########
@@ -181,7 +181,7 @@ private void
createInvertedIndexForColumn(SegmentDirectory.Writer segmentWriter,
ForwardIndexReaderContext readerContext =
forwardIndexReader.createContext()) {
if (columnMetadata.isSingleValue()) {
// Single-value column
- switch (columnMetadata.getDataType()) {
+ switch (columnMetadata.getDataType().getStoredType()) {
Review Comment:
Agreed — removed from this PR. I'll file a separate bug-fix for
BYTES/UUID/BIG_DECIMAL handling in InvertedIndexHandler's raw inverted index
path.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java:
##########
@@ -126,7 +126,7 @@ private void
createAndSealBloomFilterForDictionaryColumn(File indexDir, ColumnMe
Dictionary dictionary = getDictionaryReader(columnMetadata,
segmentWriter)) {
int length = dictionary.length();
for (int i = 0; i < length; i++) {
- bloomFilterCreator.add(dictionary.getStringValue(i));
+ bloomFilterCreator.add(dataType.toString(dictionary.getInternal(i)));
Review Comment:
Removed the UUID-specific handling from BloomFilterHandler in this PR. Will
address the correct bloom filter string representation for UUID columns (and
the missing non-dictionary SV case) in a separate bug-fix PR.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/dictionary/MutableDictionaryFactory.java:
##########
@@ -29,10 +29,11 @@ private MutableDictionaryFactory() {
public static MutableDictionary getMutableDictionary(DataType dataType,
boolean isOffHeapAllocation,
Review Comment:
The parameter is already named `valueType` in the current code — this was
already updated in an earlier revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
