xiangfu0 commented on code in PR #18165:
URL: https://github.com/apache/pinot/pull/18165#discussion_r3109011000
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpartition/SegmentPartitionMetadataManager.java:
##########
@@ -72,10 +75,12 @@ public class SegmentPartitionMetadataManager implements
SegmentZkMetadataFetchLi
private transient TablePartitionReplicatedServersInfo
_tablePartitionReplicatedServersInfo;
public SegmentPartitionMetadataManager(String tableNameWithType, String
partitionColumn, String partitionFunctionName,
Review Comment:
Done — the constructor now takes `ColumnPartitionConfig` directly and builds
the `PartitionFunction` internally.
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/metadata/ColumnPartitionMetadata.java:
##########
@@ -62,12 +65,31 @@ public class ColumnPartitionMetadata {
*/
public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
@Nullable Map<String, String> functionConfig) {
+ this(functionName, numPartitions, partitions, functionConfig, null, null);
+ }
+
+ public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
Review Comment:
The existing 4-arg public constructor is now `@Deprecated` pointing to the
new `ColumnPartitionMetadata(PartitionFunction, Set)` constructor. The private
all-fields constructor is an internal implementation detail used only by the
JSON deserializer.
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/metadata/ColumnPartitionMetadata.java:
##########
@@ -139,6 +173,11 @@ private static void addRangeToPartitions(String
rangeString, Set<Integer> partit
}
}
+ @Nullable
+ private static String normalizeOptionalText(@Nullable String value) {
+ return StringUtils.isBlank(value) || StringUtils.equalsIgnoreCase(value,
"null") ? null : value;
Review Comment:
The `StringUtils.equalsIgnoreCase()` call was already removed in an earlier
iteration — only standard `String.equalsIgnoreCase()` is used now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
