krishan1390 commented on PR #17708:
URL: https://github.com/apache/pinot/pull/17708#issuecomment-4278967678

   @rsrkpatwari1234 why do we need it in BaseRecordExtractor and not in 
ParquetNativeRecordReader / ParquetAvroRecordReader ? 
   
   The generic handling of "element" in BaseRecordExtractor seems like a hack 
and will not be applicable if the data itself is of the form
   ```
   "metadata": {"tags":[{"element":"abc"}, {"element":"xyz"}]}
   ```
   
   Additionally, the change (in any reader) will mean backward incompatibility 
for queries if they're already querying with existing data structure. I am not 
sure if thats ok to proceed or not @Jackie-Jiang . Or if we need to put the 
change behind a flag. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to