timothy-e opened a new pull request, #18287: URL: https://github.com/apache/pinot/pull/18287
Adds a new ServerMeter enum values that fire exactly once per incoming Worker.QueryRequest, giving operators a per-server MSE query count independent of stage/worker parallelism. This will help debug adaptive routing for MSE. In MSE, the broker sends a single Worker.QueryRequest to each server it dispatches to, and that single request contains all the StagePlans assigned to that server — whether those are leaf-stage plans (reading segments), intermediate-stage plans (aggregating/joining), or both. Therefore, `MSE_QUERIES` increments by exactly 1 regardless of how many stages (leaf / intermediate) are packed into that single QueryRequest. If a server happens to be assigned both a leaf stage and an intermediate stage for the same query, it still only receives one Worker.QueryRequest from the broker, and the counter goes up by 1. Matches the semantics of * [`QUERIES`](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java#L29) that exists for SSE. [We increment SSE queries before deserializing](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java#L124). * [`GRPC_QUERIES`](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java#L128) that exists for SSE GRPC requests. [We increment GRPC SSE queries before deserializing](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcQueryServer.java#L231). There was no MSE equivalent for a per-server query counter, only broker-level stats. To test, we deployed to an internal Stripe cluster and saw that the metric produces values that make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
