This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c137b75031a Add query test cases for LOOKUP join (#18279)
c137b75031a is described below
commit c137b75031ab2bb772468d1f94cbd42b98776d3f
Author: Yash Mayya <[email protected]>
AuthorDate: Wed Apr 22 09:27:59 2026 -0700
Add query test cases for LOOKUP join (#18279)
---
.../apache/pinot/query/routing/WorkerManager.java | 1 -
.../src/test/resources/queries/LookupJoin.json | 34 +++++++++++++++++++++-
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git
a/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
b/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
index 9e6e4268fd9..9c9fb6d7901 100644
---
a/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
+++
b/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
@@ -149,7 +149,6 @@ public class WorkerManager {
metadata.setWorkerIdToServerInstanceMap(workerIdToServerInstanceMap);
metadata.setPartitionFunction(childMetadata.getPartitionFunction());
// Fake a segments map so that the worker can be correctly identified
as leaf stage
- // TODO: Add a query test for LOOKUP join
Map<String, List<String>> segmentsMap =
Map.of(TableType.OFFLINE.name(), List.of());
Map<Integer, Map<String, List<String>>> workerIdToSegmentsMap =
Maps.newHashMapWithExpectedSize(workerIdToServerInstanceMap.size());
diff --git a/pinot-query-runtime/src/test/resources/queries/LookupJoin.json
b/pinot-query-runtime/src/test/resources/queries/LookupJoin.json
index eddfd84790f..73b0f03f52e 100644
--- a/pinot-query-runtime/src/test/resources/queries/LookupJoin.json
+++ b/pinot-query-runtime/src/test/resources/queries/LookupJoin.json
@@ -1,6 +1,6 @@
{
"lookup_join_basic": {
- "comment": "Tests lookup join with a dimension table. V1 and V2 pass
end-to-end. Lite mode is skipped because the broker lacks
DimensionTableDataManager. The V2 path is additionally validated at the planner
level by LookupJoinPlanTest.",
+ "comment": "Tests lookup join with a dimension table: inner/left join,
fact-side filter, and aggregation above the join. V1 and V2 pass end-to-end.
Lite mode is skipped because the broker lacks DimensionTableDataManager. The V2
path is additionally validated at the planner level by LookupJoinPlanTest.
Exercises WorkerManager.assignWorkersToNonRootFragment lookup-join branch on
the V1 path.",
"tables": {
"fact_tbl": {
"schema": [
@@ -41,6 +41,38 @@
[3, "gamma"]
],
"ignoreLiteMode": true
+ },
+ {
+ "description": "Left outer lookup join - unmatched fact row
(dim_key=4) preserved with null dim column",
+ "sql": "SELECT /*+ joinOptions(join_strategy='lookup') */
{fact_tbl}.dim_key, {dim_tbl}.name FROM {fact_tbl} LEFT JOIN {dim_tbl} ON
{fact_tbl}.dim_key = {dim_tbl}.id",
+ "outputs": [
+ [1, "alpha"],
+ [1, "alpha"],
+ [2, "beta"],
+ [3, "gamma"],
+ [4, null]
+ ],
+ "ignoreLiteMode": true
+ },
+ {
+ "description": "Lookup join with filter on fact-side column - filter
applied before the join",
+ "sql": "SELECT /*+ joinOptions(join_strategy='lookup') */
{fact_tbl}.dim_key, {fact_tbl}.metric, {dim_tbl}.name FROM {fact_tbl} JOIN
{dim_tbl} ON {fact_tbl}.dim_key = {dim_tbl}.id WHERE {fact_tbl}.metric >= 200",
+ "outputs": [
+ [2, 200, "beta"],
+ [3, 300, "gamma"],
+ [1, 400, "alpha"]
+ ],
+ "ignoreLiteMode": true
+ },
+ {
+ "description": "Aggregation above lookup join - counts matched fact
rows per dim name",
+ "sql": "SELECT /*+ joinOptions(join_strategy='lookup') */
{dim_tbl}.name, COUNT(*) FROM {fact_tbl} JOIN {dim_tbl} ON {fact_tbl}.dim_key =
{dim_tbl}.id GROUP BY {dim_tbl}.name",
+ "outputs": [
+ ["alpha", 2],
+ ["beta", 1],
+ ["gamma", 1]
+ ],
+ "ignoreLiteMode": true
}
]
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
