singhvishalkr opened a new pull request, #18302:
URL: https://github.com/apache/pinot/pull/18302
Fixes #18226. This is a targeted, behavior-neutral sweep of the low-risk
typos called out in the issue scope ("Fix obvious typos and grammar issues in
code comments and Javadocs. Keep the sweep low-risk and behavior-neutral.").
### Scope of this PR
- `occurence` -> `occurrence` in javadoc and line comments only. Left all
**parameter names** (`int occurence`, `@param occurence`) untouched because
those are part of the scalar function's public surface and renaming them would
be a user-visible change.
- `seperate` -> `separate` in config-file comments only. Left the test
method names `testStartSeperately` / `testStartSeperatelyWithStreamingUntar`
untouched so build filters and historical test-report links aren't invalidated.
### Files changed
-
`pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java`
-- Javadoc for four `strpos`-style overloads ("Return the Nth occurrence of a
substring...").
-
`pinot-common/src/main/java/org/apache/pinot/common/function/scalar/regexp/RegexpReplaceConstFunctions.java`
-- Javadoc "all occurrences. Match is performed in case-sensitive mode."
-
`pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java`
-- two `// Test occurrence` comments.
-
`pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java`
-- two `// Test occurrence` comments.
- `pinot-core/src/test/resources/conf/pinot-broker.properties` -- `# Comma
separated list of servers...`.
- `pinot-server/src/test/resources/conf/pinot-broker.properties` -- same
comment.
### Deliberately out of scope
- The `supproted` typo originally quoted from
`RefreshSegmentTaskExecutor.java` is no longer in that file on master (already
fixed at some point since the issue was filed), so nothing to do there.
- Stale TODO / FIXME wording clean-ups require per-site engineering
judgement and were left for a follow-up sweep.
- `successfull` still has around 30 hits but many are embedded in log keys,
downstream-parsed status strings, and compressor enum names where a rename
isn't comment-only; skipping for safety.
- Parameter names (`occurence` in public SQL-reachable function signatures)
are deliberately untouched to stay behavior-neutral.
### Verification
- No code paths changed; only comment and property-file comment text.
- Labels from the PR template that apply: `cleanup`, `code-style`, `testing`
(two test files touched for comment text only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
