shounakmk219 commented on code in PR #18272:
URL: https://github.com/apache/pinot/pull/18272#discussion_r3130162678
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -195,6 +201,18 @@ public PinotTaskManager(PinotHelixTaskResourceManager
helixTaskResourceManager,
LOGGER.info("Distributed locking is disabled for PinotTaskManager");
_distributedTaskLockManager = null;
}
+
+ _clusterConcurrentSchedulingEnabled =
controllerConf.isPinotTaskManagerConcurrentSchedulingEnabled();
+ LOGGER.info("Concurrent task scheduling cluster default: {}",
_clusterConcurrentSchedulingEnabled);
+ if (_clusterConcurrentSchedulingEnabled && _distributedTaskLockManager ==
null) {
+ // The concurrent path relies on the distributed ZK lock to coordinate
same-table task
+ // generation (and to mutually exclude with ad-hoc createTask, which
still takes
+ // synchronized(this)). Running without distributed locking leaves those
races unprotected.
+ LOGGER.warn("Concurrent task scheduling is enabled but distributed
locking is disabled. "
Review Comment:
I think we can call it out as a dependent feature which needs distributed
locking to be enabled to allow concurrent task generations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
