xiangfu0 commented on code in PR #18286:
URL: https://github.com/apache/pinot/pull/18286#discussion_r3130632350
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java:
##########
@@ -398,12 +433,28 @@ public Double fetchHybridScoreForServer(String server) {
}
}
+ private void removeAllServerStatsGauges() {
+ if (_serverQueryStatsMap == null) {
+ return;
+ }
+ for (String serverInstanceId : _serverQueryStatsMap.keySet()) {
+ String serverTag = "server." + serverInstanceId;
+
_brokerMetrics.removeGauge(BrokerGauge.ADAPTIVE_SERVER_NUM_IN_FLIGHT_REQUESTS.getGaugeName()
+ "." + serverTag);
+
_brokerMetrics.removeGauge(BrokerGauge.ADAPTIVE_SERVER_LATENCY_EMA.getGaugeName()
+ "." + serverTag);
+
_brokerMetrics.removeGauge(BrokerGauge.ADAPTIVE_SERVER_HYBRID_SCORE.getGaugeName()
+ "." + serverTag);
+ }
+ LOGGER.info("Removed adaptive server routing stats gauges for {}
servers.", _serverQueryStatsMap.size());
+ }
+
private void recordQueueSizeMetrics() {
int queueSize = getQueueSize();
_brokerMetrics.setValueOfGlobalGauge(BrokerGauge.ROUTING_STATS_MANAGER_QUEUE_SIZE,
queueSize);
}
private void exportStatsAsMetrics() {
+ if (!_enableStatsMetricExport) {
Review Comment:
This flag is written by the Helix cluster-config callback but read by this
scheduled export thread without a happens-before edge. Because
`_enableStatsMetricExport` is still a plain boolean, brokers are not guaranteed
to observe dynamic enable/disable updates, so metrics can keep exporting after
the config is disabled or remain off after it is enabled. Make the flag
volatile or use an AtomicBoolean (and synchronize any related reschedule state
as needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
