Jackie-Jiang commented on code in PR #18313:
URL: https://github.com/apache/pinot/pull/18313#discussion_r3133893542
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -1264,6 +1263,17 @@ protected SegmentMessageHandlerFactory
createSegmentMessageHandlerFactory(Instan
return new SegmentMessageHandlerFactory(instanceDataManager,
serverMetrics);
}
+ /**
+ * Creates the {@link SegmentOnlineOfflineStateModelFactory} used to handle
Helix state transitions for segments.
+ * The {@link StateTransitionThreadPoolManager} should be initialized by
+ * {@link BaseServerStarter#initTransitionThreadPoolManager()} before this
method is called.
+ * Subclasses can override to return a custom factory.
+ */
+ protected SegmentOnlineOfflineStateModelFactory
createSegmentOnlineOfflineStateModelFactory(
+ InstanceDataManager instanceDataManager) {
Review Comment:
Let's also pass in _transitionThreadPoolManager. We can change the
constructor of `SegmentOnlineOfflineStateModelFactory` to not take
`_instanceId` and read it from `instanceDataManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
