dang-stripe commented on code in PR #18268:
URL: https://github.com/apache/pinot/pull/18268#discussion_r3134787735
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -2203,6 +2203,28 @@ public static class PlanVersions {
/// TODO: This is used by the broker. Consider renaming it.
public static final String KEY_OF_CANCEL_TIMEOUT_MS =
"pinot.server.query.cancel.timeout.ms";
public static final long DEFAULT_OF_CANCEL_TIMEOUT_MS = 1000;
+
+ /// gRPC keep-alive time for broker dispatch channels, in milliseconds.
Values > 0 enable keep-alive pings so
+ /// that a silently unreachable server (e.g. kernel-dead node, one-way
network partition) transitions the dispatch
+ /// channel out of `READY`, which in turn lets the broker's
FailureDetector exclude it from routing.
+ ///
+ /// Defaults are chosen to be safe against Netty's default gRPC server
enforcement
+ /// (`permitKeepAliveTime` = 5 minutes, `permitKeepAliveWithoutCalls` =
false); operators may tune these down for
+ /// faster silent-peer detection once the server side has been configured
to permit a higher ping rate.
Review Comment:
@yashmayya We were working on this internally as well so good to get
validation on the solution. Are you running this with a setting lower than 5
minutes?
I was under the assumption that exposing `permitKeepAliveTime` to match this
value is needed on the server side otherwise going any lower than the default 5
minutes will cause `GOAWAY` and the connection will get killed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
