xiangfu0 opened a new pull request, #18315:
URL: https://github.com/apache/pinot/pull/18315
## Summary
The Rebalance Servers Status dialog (Tenant Details → Rebalance Servers
Status) declared 5 column headers (`Job id, Table name, Status, Started at,
Finished at`) but each row only emitted 4 cells. As a result:
- The computed finish time (`submissionTimeMs + timeToFinishInSeconds *
1000`) was rendered under the **Started at** header.
- The **Finished at** column was always blank.
- For in-progress jobs (`timeToFinishInSeconds == 0`) the "Started at"
column collapsed to `submissionTimeMs`, which can differ from the authoritative
`startTimeMs` reported by the controller — and didn't match what the job-detail
response showed after clicking.
### Fix
In `RebalanceServerStatusOp.tsx`:
- Parse `REBALANCE_PROGRESS_STATS` once per row with a `|| '{}'` guard.
- Use `progressStats.startTimeMs` for **Started at**, falling back to
`submissionTimeMs` only when the rebalance hasn't recorded one yet (backend
default `0L`).
- Render **Finished at** as `startTimeMs + timeToFinishInSeconds * 1000`
only when `timeToFinishInSeconds > 0`; otherwise `-`.
The row now produces 5 cells, matching the 5 column headers.
Note: the related title/button mismatch (`Rebalance Table Status` vs
`Rebalance Servers Status`) was already fixed in #16545.
Fixes #15939
## Test plan
- [ ] Open Tenant Details → Rebalance Servers Status while a rebalance is in
progress and verify **Started at** matches `startTimeMs` in the detail view
(not `submissionTimeMs`).
- [ ] Verify two concurrent in-progress jobs show their individual start
times (not identical).
- [ ] Verify **Finished at** is blank (`-`) for in-progress jobs and
populated after the job completes.
- [ ] Verify refresh does not change the displayed start time.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
