xiangfu0 commented on code in PR #18312:
URL: https://github.com/apache/pinot/pull/18312#discussion_r3141916967
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -142,7 +142,8 @@ public abstract class BaseTableDataManager implements
TableDataManager {
protected File _resourceTmpDir;
protected Logger _logger;
protected SegmentReloadSemaphore _segmentReloadSemaphore;
- protected ExecutorService _segmentReloadRefreshExecutor;
+ protected ExecutorService _segmentReloadExecutor;
Review Comment:
This also removes the protected `_segmentReloadRefreshExecutor` field from a
public abstract base class. Downstream subclasses compiled against that field
will fail with `NoSuchFieldError` after upgrade even though the underlying pool
is unchanged. If we need separate wrappers, please keep the legacy field as a
deprecated alias (or add a compatibility accessor) until the next compatibility
window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
