tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3169265435
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##########
@@ -619,6 +619,9 @@ public void validate() {
FieldType fieldType = fieldSpec.getFieldType();
DataType dataType = fieldSpec.getDataType();
String fieldName = fieldSpec.getName();
+
Preconditions.checkState(!ColumnarMapNaming.isColumnarMapVirtualColumn(fieldName),
Review Comment:
This make sense. I will defer this validation in TableConfigValidation which
will trigger only if a column has columnar_map being added or we are adding a
new column with `$__` on a table that already has columnar_map.
This will make it backward compatible. Will add this in the future PR where
I add imp details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
