J-HowHuang commented on code in PR #18398:
URL: https://github.com/apache/pinot/pull/18398#discussion_r3184568299
##########
pinot-tools/src/main/resources/examples/stream/airlineStats/docker/airlineStats_realtime_table_config.json:
##########
@@ -7,7 +7,6 @@
"retentionTimeUnit": "DAYS",
"retentionTimeValue": "5",
"segmentPushType": "APPEND",
- "segmentAssignmentStrategy": "BalanceNumSegmentAssignmentStrategy",
Review Comment:
This field is not consumed by anyone currently, so it should have
effectively the same behavior after removing it. The
`SegmentAssignmentStrategyFactory#getSegmentAssignmentStrategy` has been the
one who figures out the strategy to use.
The new config:
```
"segmentAssignmentConfigMap": {
"OFFLINE": {
"segmentAssignmentStrategy": "BalanceNumSegmentAssignmentStrategy"
}
}
```
serves more like an override, IMO we don't need to provide them in the
example table config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
