xiangfu0 commented on code in PR #18428:
URL: https://github.com/apache/pinot/pull/18428#discussion_r3191964420
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionUtils.java:
##########
@@ -57,65 +56,14 @@ private FunctionUtils() {
put(float[].class, PinotDataType.PRIMITIVE_FLOAT_ARRAY);
put(double[].class, PinotDataType.PRIMITIVE_DOUBLE_ARRAY);
put(BigDecimal[].class, PinotDataType.BIG_DECIMAL_ARRAY);
+ put(boolean[].class, PinotDataType.PRIMITIVE_BOOLEAN_ARRAY);
+ put(Timestamp[].class, PinotDataType.TIMESTAMP_ARRAY);
put(String[].class, PinotDataType.STRING_ARRAY);
put(byte[][].class, PinotDataType.BYTES_ARRAY);
put(Map.class, PinotDataType.MAP);
put(Object.class, PinotDataType.OBJECT);
}};
- // Types allowed as the function argument (actual value passed into the
function) for type conversion
- private static final Map<Class<?>, PinotDataType> ARGUMENT_TYPE_MAP = new
HashMap<>() {{
- put(Byte.class, PinotDataType.BYTE);
- put(Boolean.class, PinotDataType.BOOLEAN);
- put(Character.class, PinotDataType.CHARACTER);
- put(Short.class, PinotDataType.SHORT);
Review Comment:
do we ever support BYTE/CHAR/SHORT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
