Jackie-Jiang opened a new pull request, #18451: URL: https://github.com/apache/pinot/pull/18451
## Summary Adds a default `addBigDecimal(BigDecimal, int)` method to the `IndexCreator` interface and overrides it in `ForwardIndexCreator`, mirroring the existing typed SV adders. ## Motivation `IndexCreator` already has typed SV adders for INT / LONG / FLOAT / DOUBLE / STRING / BYTES, and a typed MV adder for BIG_DECIMAL (`addBigDecimalMV`). The SV variant for BIG_DECIMAL was the only gap, forcing creators that want a typed `BigDecimal` entry point to fall back to the boxed `add(Object, int)`. ## Changes - `IndexCreator#addBigDecimal(BigDecimal, int)` — default delegates to `add(Object, int)`, consistent with the other typed SV adders. - `ForwardIndexCreator` overrides `addBigDecimal` with the same dispatch pattern as its sibling typed adders: `putDictId(dictId)` when dictionary-encoded, `putBigDecimal(value)` otherwise. ## Compatibility Backward-compatible: default delegates to `add(Object, int)`, so existing implementations are unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
