tarun11Mavani commented on code in PR #18437:
URL: https://github.com/apache/pinot/pull/18437#discussion_r3206410495
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/datasource/MapDataSource.java:
##########
@@ -23,30 +23,22 @@
import org.apache.pinot.spi.data.ComplexFieldSpec;
+/// DataSource for a MAP column. Provides per-key DataSources that can be used
for filtering,
+/// aggregation, and projection on individual MAP keys.
public interface MapDataSource extends DataSource {
- /**
- * Get the map FieldSpec.
- */
+ /// Returns the map FieldSpec.
ComplexFieldSpec.MapFieldSpec getFieldSpec();
- /**
- * Get the Data Source representation of a single key within this map column.
- */
- DataSource getKeyDataSource(String key);
-
- /**
- * Get the Data Source representation of all keys within this map column.
- */
- Map<String, DataSource> getKeyDataSources();
-
- /**
- * Get the DataSourceMetadata of a single key within this map column.
- */
- DataSourceMetadata getKeyDataSourceMetadata(String key);
-
- /**
- * Get the IndexContainer of a single key within this map column.
- */
- ColumnIndexContainer getKeyIndexContainer(String key);
+ /// Returns the DataSource for the given map key's values.
+ DataSource getDataSource(String key);
Review Comment:
make sense. Will close the PR.
for new API added in columnar_map, I am using correct name (getXXX).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
