Akanksha-kedia opened a new pull request, #18472:
URL: https://github.com/apache/pinot/pull/18472
## Summary
Closes #17072 (supersedes and expands the original PR per reviewer feedback
from @xiangfu0).
The `@Deprecated` `_segmentPushType` and `_segmentPushFrequency` fields,
their associated private constants (`DEFAULT_SEGMENT_PUSH_TYPE`,
`REFRESH_SEGMENT_PUSH_TYPE`), the deprecated setter methods
(`setSegmentPushType`, `setSegmentPushFrequency`), and their forwarding in
`build()` have all been removed from `TableConfigBuilder`.
The authoritative path for these values is `IngestionConfig →
BatchIngestionConfig → segmentIngestionType / segmentIngestionFrequency`.
`TableConfigUtils.repairTableConfig()` already migrates any legacy persisted
configs (read from ZK) that carry these values in
`SegmentsValidationAndRetentionConfig`.
### Callers updated
| File | Change |
|---|---|
| `HelixExternalViewBasedQueryQuotaManagerTest` | Remove 6 redundant
`.setSegmentPushType("APPEND")` calls — irrelevant to quota logic |
| `MultiStageEngineIntegrationTest` | Remove 1 redundant
`.setSegmentPushType("APPEND")` call |
| `TimeBoundaryManagerTest` | Set `segmentPushFrequency` directly on the
validation config to simulate a legacy table config |
| `TableConfigUtilsTest.testConvertFromLegacyTableConfig` | Set push
type/frequency directly on the validation config, matching how legacy configs
are stored on disk, then verify `convertFromLegacyTableConfig` migrates them
correctly |
## Test plan
- [ ] `TableConfigUtilsTest.testConvertFromLegacyTableConfig` passes —
migration of legacy validation-config push type/frequency still works
- [ ] `TimeBoundaryManagerTest` passes — push frequency is still propagated
correctly
- [ ] `HelixExternalViewBasedQueryQuotaManagerTest` passes — quota logic
unaffected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
