noob-se7en commented on code in PR #18360:
URL: https://github.com/apache/pinot/pull/18360#discussion_r3225645888
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/StreamOp.java:
##########
@@ -277,8 +277,12 @@ private long fetchExistingTotalDocs(String tableName)
String errorMsg =
String.format("Failed when running query: '%s'; got
exceptions:\n%s\n", query, response.toPrettyString());
JsonNode exceptions = response.get(EXCEPTIONS);
- JsonNode errorCode = exceptions.get(ERROR_CODE);
- if (QueryErrorCode.BROKER_INSTANCE_MISSING.getId() == errorCode.asInt())
{
+ // exceptions is a JSON array; iterate to find any transient error code
before failing
Review Comment:
this StreamOp fix (NPE on `exceptions.get(ERROR_CODE)` because `exceptions`
is a JSON array, plus adding `BROKER_SEGMENT_UNAVAILABLE` to the retry-on list)
is a real bug fix, but it's unrelated to GcsPinotFS null safety. different
module, different bug class, not mentioned in the PR title/description. worth
splitting into its own PR so it gets reviewed on its own merits and survives
any future revert of the GCS portion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
