Jackie-Jiang opened a new pull request, #18481: URL: https://github.com/apache/pinot/pull/18481
## Summary - Moves `PinotDataType` from `pinot-common/.../utils/` to `pinot-spi/.../utils/`, with the matching test (`PinotDataTypeTest`). The class previously held one pinot-common-specific helper, `getPinotDataTypeForExecution(ColumnDataType)`, which is moved onto `ColumnDataType` as the instance method `toPinotDataType()` — leaving `PinotDataType` free of any `pinot-common` references. - Updates the 22 import declarations across the codebase to the new package, plus two `config/checkstyle.xml` entries that allow `PinotDataType.*` static imports. - The single existing caller of the moved helper (`PostAggregationFunction`) is updated to call `argumentTypes[i].toPinotDataType()`. ## Motivation `pinot-spi` modules (e.g. `ColumnReader`) currently can't reference `PinotDataType` because of the dependency direction (`pinot-common` → `pinot-spi`). After this move, the SPI's value-type APIs can return a `PinotDataType` directly — which encodes SV/MV + Java representation in one value — instead of pairing `FieldSpec.DataType` with a separate `isSingleValue()` flag. This enables downstream simplifications such as collapsing `DataTypeColumnTransformer.isNoOp()` to a single equality check against the destination type. No behavior change; pure code motion plus the rename of one helper. ## Test plan - [ ] Existing unit tests (`PinotDataTypeTest` runs in `pinot-spi` now) - [ ] `mvn -pl pinot-spi,pinot-common,pinot-core,pinot-query-runtime,pinot-segment-local -am test` 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
