xiangfu0 commented on code in PR #18469:
URL: https://github.com/apache/pinot/pull/18469#discussion_r3234053200
##########
pinot-spi/pom.xml:
##########
@@ -290,7 +290,35 @@
</dependency>
<dependency>
<groupId>org.codehaus.groovy</groupId>
- <artifactId>groovy-all</artifactId>
+ <artifactId>groovy</artifactId>
Review Comment:
This narrows Pinot's shipped Groovy runtime from the old `groovy-all` fat
jar to a hand-picked subset, which is a backward-compat break for clusters that
have Groovy enabled. Pinot can run with Groovy static analysis unset, and the
current 2.4 jar on the runtime classpath includes classes like
`groovy.util.CliBuilder` and `groovy.jmx.builder.JmxBuilder`; those disappear
with this dependency list, so existing transform/query scripts can start
failing with `ClassNotFoundException` after upgrade even though CI stays green.
This needs either a compatibility-preserving runtime surface or an explicit
breaking-change rollout plus parity coverage for the supported Groovy modules.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
