raghavyadav01 commented on PR #18504: URL: https://github.com/apache/pinot/pull/18504#issuecomment-4456442042
One more — `ProjectionBlockValSet.isDictionaryEncoded()` (and `ColumnContext.fromDataSource`): ```java return forwardIndex == null || forwardIndex.isDictionaryEncoded(); // null → true ``` When forward index is disabled (dict + inverted/range only, no forward index — a real Pinot feature), this returns `true`, callers take the dict-id path, and `getDictionaryIdsSV()` will NPE. Pre-existing behavior in master too, but worth tightening to `forwardIndex != null && forwardIndex.isDictionaryEncoded()` while we're here. Should we fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
