gortiz commented on code in PR #18387:
URL: https://github.com/apache/pinot/pull/18387#discussion_r3258323907
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotQueryRuleSets.java:
##########
@@ -229,44 +260,12 @@ private PinotQueryRuleSets() {
);
//@formatter:on
- /// Pinot specific rules that should be run AFTER all other rules
+ /// Pinot specific post-logical rules.
+ ///
+ /// <p>The {@code sortExchangeCopyLimit} parameter is <b>no longer applied
here</b>. Per-query
+ /// sort-exchange-copy threshold overrides are now handled by {@code
QueryEnvironment.getTraitProgram},
+ /// which swaps the rule on a per-query copy of {@link #POST_LOGICAL_RULES}.
public static List<RelOptRule> getPinotPostRules(int sortExchangeCopyLimit) {
Review Comment:
Correct — no callers in this codebase either, so the method was removed
entirely.
Keeping a public method that silently ignores its argument is worse than the
compile error removal would cause to out-of-tree callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
