gortiz commented on code in PR #18519:
URL: https://github.com/apache/pinot/pull/18519#discussion_r3266804406
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxService.java:
##########
@@ -190,6 +236,37 @@ public boolean resetConnectBackoff(String hostname, int
port) {
return _channelManager.resetConnectBackoff(hostname, port);
}
+ /// Current value of [BrokerGauge#MAILBOX_CLIENT_USED_DIRECT_MEMORY] /
+ /// [ServerGauge#MAILBOX_CLIENT_USED_DIRECT_MEMORY] — bytes pinned by the
+ /// shared gRPC client allocator backing every [GrpcSendingMailbox] created
+ /// from this service.
+ public long getMailboxClientUsedDirectMemoryBytes() {
Review Comment:
Done — all four (`getMailboxClientUsedDirectMemoryBytes`,
`getMailboxClientUsedHeapMemoryBytes`, `getMailboxServerUsedDirectMemoryBytes`,
`getMailboxServerUsedHeapMemoryBytes`) are now annotated `@VisibleForTesting`
at `MailboxService.java:252/259/269/278`. They're still `public` because
Pinot's `@VisibleForTesting` convention is the annotation only (no
enforcement), but the annotation makes the intent explicit and grep-able.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
