gortiz commented on code in PR #18458:
URL: https://github.com/apache/pinot/pull/18458#discussion_r3268052109
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OpChainExecutionContext.java:
##########
@@ -63,6 +67,25 @@ public class OpChainExecutionContext {
private ServerPlanRequestContext _leafStageContext;
private final boolean _sendStats;
private final boolean _keepPipelineBreakerStats;
+ /**
+ * Map of MultiStageOperator -> PlanNodes that compile down to that
operator. Populated by
+ * {@link org.apache.pinot.query.runtime.plan.PlanNodeToOpChain} during
opchain construction. Cardinality is
+ * one-to-many: an intermediate operator maps to a single PlanNode, but the
leaf operator maps to the whole sub-tree
+ * of v1 plan nodes below the leaf-stage boundary. Used by the stream-mode
stats reporting path
+ * ({@code MultiStageStatsTreeEncoder}) to attach plan-node identifiers to
each operator's stats.
+ * <p>
+ * Identity-based (IdentityHashMap) because PlanNode equality is structural
and two distinct nodes can compare equal.
+ */
+ private final Map<MultiStageOperator, List<PlanNode>> _operatorToPlanNodes =
new IdentityHashMap<>();
Review Comment:
This is a valid concern. I'll work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
