xiangfu0 commented on code in PR #18532:
URL: https://github.com/apache/pinot/pull/18532#discussion_r3268695652
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/StreamOp.java:
##########
@@ -266,21 +281,27 @@ private boolean produceData() {
private long fetchExistingTotalDocs(String tableName)
throws Exception {
String query = "SELECT count(*) FROM " + tableName;
- JsonNode response = Utils.postSqlQuery(query,
ClusterDescriptor.getInstance().getBrokerUrl());
+ JsonNode response;
+ try {
+ response = Utils.postSqlQuery(query,
ClusterDescriptor.getInstance().getBrokerUrl());
+ } catch (Exception e) {
+ throw new RetryableQueryException(String.format("Failed to query Table:
%s", tableName), e);
Review Comment:
Applied. This now catches only `IOException` from the broker POST/response
read path; query failures that come back as broker JSON exceptions are still
classified by `errorCode`, and non-retryable query errors fail fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
