rsrkpatwari1234 commented on code in PR #18175:
URL: https://github.com/apache/pinot/pull/18175#discussion_r3269160581
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -369,27 +379,40 @@ void setClock(Clock clock) {
_clock = clock;
}
+ /** Table key for ingestion gauges for {@code pinotPartitionId}, aligned
with stream consumer metrics. */
+ private String getIngestionGaugeTableKey(int pinotPartitionId) {
+ TableConfig tableConfig =
_realTimeTableDataManager.getCachedTableConfigAndSchema().getLeft();
+ List<StreamConfig> streamConfigs =
IngestionConfigUtils.getStreamConfigs(tableConfig);
+ StreamConfig streamConfig =
IngestionConfigUtils.getStreamConfigFromPinotPartitionId(streamConfigs,
+ pinotPartitionId);
+ int streamPartitionId =
Review Comment:
For single-topic tables,
`IngestionConfigUtils.getStreamPartitionIdFromPinotPartitionId(tableConfig,
pinotPartitionId)` returns `pinotPartitionId` as-is (no % 10000 remap). That
matches `RealtimeSegmentDataManager`, which uses `_streamPartitionId =
_partitionGroupId` when there is only one stream. So which physical partition
the delay refers to, is unchanged for single-topic.
We only change the metric identity from “table + Pinot partition only” to
the same tableNameWithType-topic-streamPartition shape as stream consumer
metrics, so a topic label (and consistent partition labeling) appears. Hence
users would have to update the dashboards and alerts which rely on these
metrices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
