jineshparakh commented on code in PR #18515:
URL: https://github.com/apache/pinot/pull/18515#discussion_r3271597506
##########
pinot-broker/src/test/java/org/apache/pinot/broker/api/resources/PinotClientRequestTest.java:
##########
@@ -171,16 +173,65 @@ public void testPinotQueryComparisonApiDifferentQuery()
throws Exception {
}
@Test
- public void testPinotQueryComparisonApiMissingSql() throws Exception {
+ public void testPinotQueryComparisonApiMissingV2Sql() throws Exception {
Review Comment:
I don't think the Jersey level integration test is needed. There's no
existing JerseyTest harness in pinot-broker.
Unit tests are enough for this validation as per me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
