mayankshriv commented on PR #18552: URL: https://github.com/apache/pinot/pull/18552#issuecomment-4504776701
Thanks for the review @deepthi912! **Re: upsert toggle ([comment](https://github.com/apache/pinot/pull/18552#discussion_r3278424631))** — Agreed, this is a supported workflow. Removed the upsert toggle violation in the latest push; it's back to the original INFO-level logging. **Re: consistencyMode ([comment](https://github.com/apache/pinot/pull/18552#discussion_r3278516096))** — Makes sense — consistencyMode change is an operational tuning decision, not data-corrupting. Removed this check in the latest push. The PR now only adds the missing `deleteRecordColumn` check (which was already documented in the javadoc but never implemented). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
